URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cc72c2e8a20b23e6f447991b26b05d1eecc0724b
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark
Commits:
cc72c2e by Jim Young (jyoung@xxxxxxx):
profiles: Try to better sync on disk config state
Profile specific column settings are split across the `preferences'
file and the `recent' file. At any given moment the GUI column
settings held within the `preferences' file and the `recent' file
may be inconsistent with one another and with the GUI itself. These
inconsistencies occur because of when the GUI chooses to write
config changes to disk.
If Wireshark is not shutdown gracefully (for example when killed
or should crash) the column preferences saved on disk may not be
consistent between the current profile's `preferences` and `recent`
files and the most recently used profile may not be recorded within
the `recent_common' file. On restarting Wireshark these config file
inconsistencies can lead to unexpected artifacts.
Normally the column config state saved within the current profile's
`preferences' and `recent` files are made consistent when a
different profile is selected or when Wireshark is closed
gracefully.
This patch set attempts to improve the constancy of the on disk
config state with the GUI state by invoking the functions to write
the `recent' and `recent_common' files in a more timely manner.
Fix a typo while here.
Change-Id: I2af9d9eb2dcf9cc0d422e9840aa05f4f6b1aa086
Reviewed-on: https://code.wireshark.org/review/35407
Petri-Dish: Jim Young <jim.young.ws@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jim Young <jim.young.ws@xxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit 8fbe28b1f0b24fee1e1a27ccdb6b8f893c43f133)
Reviewed-on: https://code.wireshark.org/review/35463
Actions performed:
from bb82f65 pcfp: add missing Usage Report Trigger indication
add cc72c2e profiles: Try to better sync on disk config state
Summary of changes:
ui/preference_utils.c | 6 +++++-
ui/qt/wireshark_application.cpp | 7 +++++--
ui/qt/wireshark_application.h | 2 +-
ui/recent.c | 7 ++++---
ui/recent.h | 2 +-
5 files changed, 16 insertions(+), 8 deletions(-)