Wireshark-commits: [Wireshark-commits] master 3e0acea: CMake: Fixup a variable in FindLZ4.cmake

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 Dec 2019 04:55:52 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3e0acea60488ac51ff9f181266b7e4f5928248d3
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3e0acea by Gerald Combs (gerald@xxxxxxxxxxxxx):

    CMake: Fixup a variable in FindLZ4.cmake
    
    Set "LZ4_PDB" instead of "LZ4_pdb" in FindLZ4.cmake so that CMake 3.16
    will convert "${LZ4_DLL_DIR}/${LZ4_PDB}" to the full path to the LZ4
    .pdb instead of its parent directory.
    
    This in turn ensures that we don't pass a directory as a source argument
    to `cmake -E copy_if_different`, which causes it to crash.
    
    Bug: 16271
    Change-Id: Id6f37584379bd07bc929bc5cb5e80cbe60a3c77e
    Reviewed-on: https://code.wireshark.org/review/35400
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2db8ca2   radiotap: Detect 11ad based on the frequency.
     add  3e0acea   CMake: Fixup a variable in FindLZ4.cmake


Summary of changes:
 cmake/modules/FindLZ4.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)