Wireshark-commits: [Wireshark-commits] master 718837a: Bugfix SMB IOCTL response with BUFFER_OVERFL

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 08 Dec 2019 15:08:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=718837ac45ef3b74d6e1444ec36055ff55443767
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

718837a by Volodymyr Khomenko (volodymyr@xxxxxxxxxxxx):

    Bugfix SMB IOCTL response with BUFFER_OVERFLOW
    
    In case if SMB IOCTL response packet (seen to happen for FSCTL_PIPE_TRANSCEIVE but applicable for others)
    has STATUS_BUFFER_OVERFLOW status code, dissection is done improperly
    (wrong offset to IOCTL response body is calculated so content is corrupted).
    Packet body with STATUS_BUFFER_OVERFLOW status should be handled in the same way as STATUS_SUCCESS packet.
    
    Bug: 16261
    Change-Id: I05d05ed9fa16f8b128590cd505fe9b0270dd74ab
    Reviewed-on: https://code.wireshark.org/review/35341
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8de7163   s7comm: Add decoding of some more SZL indices
     add  718837a   Bugfix SMB IOCTL response with BUFFER_OVERFLOW


Summary of changes:
 epan/dissectors/packet-smb2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)