URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6c686c775ca055c4e6e23d1a734c6b4af888819c
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark
Commits:
6c686c7 by Tomasz Moń (desowin@xxxxxxxxx):
wsutil: Fix 30 seconds freeze if process fails to start
In ws_pipe_wait_for_pipe() on Windows, the WaitForMultipleObjects() waits
on the pending pipe connection events and process handle. If the process
handle is signalled, then it means that the process did exit without
connecting to the pipes.
The WaitForMultipleObjects() was not waiting on the process handle and thus
if the process did fail without connecting to pipes the Wireshark gui was
frozen for 30 seconds.
This change fixes the freeze by increasing the number of handles, so
WaitForMultipleObjects() is aware of the process handle.
Change-Id: Id13824a60baf4be7795cbe1d5ed1c7932edbff45
Reviewed-on: https://code.wireshark.org/review/33028
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
(cherry picked from commit b075b8c7f7bc88b3d2811ac46c40bd677c5464ee)
Reviewed-on: https://code.wireshark.org/review/35292
Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Actions performed:
from 3dd28d3 ws_pipe: fix return value of ws_pipe_spawn_async on error path
add 6c686c7 wsutil: Fix 30 seconds freeze if process fails to start
Summary of changes:
wsutil/ws_pipe.c | 1 +
1 file changed, 1 insertion(+)