URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bdd14119aaf5413200d488ed45adebb5eca3f57a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark
Commits:
bdd1411 by Jirka Novak (j.novak@xxxxxxxxxxxx):
rtp_analysis_dialog.cpp: save any supported codec as .au
Change improves Wireshark ability to save rtp streams. It allows a user
to save any supported codec with 8 kHz rate. In real, it means G.711 and
G.729 for now.
There is no hardcoded codec limitation during save anymore. If code detects
unsupported codec or rate during save, it replaces samples with silence and
reports it. Therefore any added codec in future will be supported.
Note to RTP saving:
RTP streams (there can be up to two of them for save) can contain multiple
codecs in each direction - some of it can be supported and some
unsupported. What should be exported then?
Till my patch save do not run and a user received nothing even part of stream
was OK/encoded with supported codec.
Therefore I managed the code to start with export and do its best.
Unknown codec/part is replaced with silence and user is warned after
export. Therefore a user will get:
a) audio - when all codecs are supported (no warning)
b) mix audio/silence - when some codecs are supported (warning)
c) only silence - when no codec is supported (warning)
BTW same output user sees/gets in RTP player for years.
Change-Id: Id938d419f5841af46d2d2d3ddfaf1ec9a0235bcc
Reviewed-on: https://code.wireshark.org/review/35105
Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
Reviewed-on: https://code.wireshark.org/review/35183
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from d52cbce print: remove assert in get_field_data().
add bdd1411 rtp_analysis_dialog.cpp: save any supported codec as .au
Summary of changes:
docbook/release-notes.adoc | 1 +
ui/qt/rtp_analysis_dialog.cpp | 328 +++++++++++++++++++++++-------------------
ui/qt/rtp_analysis_dialog.h | 26 ++--
ui/rtp_media.c | 36 +++--
ui/rtp_media.h | 16 ++-
5 files changed, 238 insertions(+), 169 deletions(-)