Wireshark-commits: [Wireshark-commits] master-3.0 e964fc1: print: remove assert in get_field_data()

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 21 Nov 2019 09:47:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e964fc198c7d8e0aa8ade76b5bd06df8cee880e7
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

e964fc1 by Dario Lombardo (lomato@xxxxxxxxx):

    print: remove assert in get_field_data().
    
    The check in the caller suggests this function can fail. The
    assert should not be necessary, then.
    
    Bug: 16218
    Change-Id: Ic2186f3c51751db61436719bbf5bce609d364d40
    Reviewed-on: https://code.wireshark.org/review/35162
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 986fec7f3ba9db9b60fe209fb5d41ba5d291cde5)
    Reviewed-on: https://code.wireshark.org/review/35174
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  d512eb1   Release notes: The Windows installers ship with Qt 5.12.6.
     add  e964fc1   print: remove assert in get_field_data().


Summary of changes:
 epan/print.c | 1 -
 1 file changed, 1 deletion(-)