Wireshark-commits: [Wireshark-commits] master 11be78a: NSIS: Don't run Wireshark from the installer

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 20 Nov 2019 04:39:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=11be78a61f0804c79ff35451edc9f2bf077733b0
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

11be78a by Gerald Combs (gerald@xxxxxxxxxxxxx):

    NSIS: Don't run Wireshark from the installer.
    
    Remove the option to run Wireshark from the NSIS installer. As noted in
    bug 16195, this runs Wireshark as Administrator which is something we
    recommend against.
    
    Bug: 16195
    Change-Id: I0692262a611d72d9e9f9c2131ce71cc62b4737b1
    Reviewed-on: https://code.wireshark.org/review/35143
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9de7cd9   Remove "..." from end of Edit > Copy > As XXX menu items.
     add  11be78a   NSIS: Don't run Wireshark from the installer.


Summary of changes:
 packaging/nsis/wireshark.nsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)