Wireshark-commits: [Wireshark-commits] master 7cc5f4c: CMake: Work correctly without Sparkle.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 15 Nov 2019 22:34:12 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7cc5f4c45f9792f2cd3d207efed48aa021bdffd4
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7cc5f4c by Gerald Combs (gerald@xxxxxxxxxxxxx):

    CMake: Work correctly without Sparkle.
    
    Set or clear SPARKLE_LIBRARIES and SPARKLE_INCLUDE_DIRS in
    FindSparkle.cmake, similar to what we do in other modules. Use them
    instead of SPARKLE_LIBRARY and SPARKLE_INCLUDE_DIR.
    
    Change-Id: I023c711edd6a44421aadf85413da3207d9b08e64
    Reviewed-on: https://code.wireshark.org/review/35097
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  e624545   tools: fix echo in bsd-setup.
     add  7cc5f4c   CMake: Work correctly without Sparkle.


Summary of changes:
 CMakeLists.txt                  |  4 ++--
 cmake/modules/FindSparkle.cmake | 15 ++++++++++++---
 packaging/macosx/osx-app.sh.in  |  2 +-
 3 files changed, 15 insertions(+), 6 deletions(-)