Wireshark-commits: [Wireshark-commits] master c6dff59: dot11decrypt: Fix MIC calc for HMAC-SHA384

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 14 Nov 2019 08:28:12 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c6dff594b9b992b0e5809d35e1a754e39c190192
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c6dff59 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    dot11decrypt: Fix MIC calc for HMAC-SHA384
    
    The temporary buffer to store calculated mic is too short to keep
    the message digest when using HMAC-SHA384 algo. HMAC-SHA384 yields
    a message digest of 48 bytes so increase buffer size to make room
    for the largest possible value.
    
    Ping-Bug: 16197
    Change-Id: I36fd094c39ce77329fb303fa181d286be694ae65
    Reviewed-on: https://code.wireshark.org/review/35067
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b07dada   dot11decrypt: Fix KDF for larger PTK derivation
     add  c6dff59   dot11decrypt: Fix MIC calc for HMAC-SHA384


Summary of changes:
 epan/crypt/dot11decrypt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)