Wireshark-commits: [Wireshark-commits] master 96971a3: dot11decrypt: Support dynamic MIC lengths

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 14 Nov 2019 08:27:27 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=96971a33a3316f333fbf5072b702a6837a376085
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

96971a3 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    dot11decrypt: Support dynamic MIC lengths
    
    Not all AKMS use same MIC length. Last part to support both 16 byte
    24 byte long MIC is to actually make use of the now known in mic
    length in MIC check / validation function. Instead of hardcoded
    length use the length in eapol_parsed struct received from
    dissector.
    
    Ping-Bug: 16197
    Change-Id: I6585b7a54de4def9e5ff846c19f12059b90ffdf6
    Reviewed-on: https://code.wireshark.org/review/35063
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ccc591d   [RFC]ieee80211: Fix function to determine mic length
     add  96971a3   dot11decrypt: Support dynamic MIC lengths


Summary of changes:
 epan/crypt/dot11decrypt.c        | 22 ++++++++++++++--------
 epan/crypt/dot11decrypt_system.h |  2 +-
 2 files changed, 15 insertions(+), 9 deletions(-)