Wireshark-commits: [Wireshark-commits] master e023908: SNMP: do not modify the ASN.1 source for req

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 07 Nov 2019 18:40:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e0239089525e904e3f11206f6296addf138a9125
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e023908 by Pascal Quantin (pascal@xxxxxxxxxxxxx):

    SNMP: do not modify the ASN.1 source for request/response tracking
    
    Follow-up of g14d398fe67
    
    Change-Id: Ic6c4966d8a9a1a53c8d7daeeda7fd71779f9b07d
    Reviewed-on: https://code.wireshark.org/review/35025
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  04e400d   Fix problems regarding SRT calculation in SNMP dissector
     add  e023908   SNMP: do not modify the ASN.1 source for request/response tracking


Summary of changes:
 epan/dissectors/asn1/snmp/snmp.asn | 19 +++++++--------
 epan/dissectors/asn1/snmp/snmp.cnf |  6 ++++-
 epan/dissectors/packet-snmp.c      | 49 +++++++++++++++++++++++++-------------
 3 files changed, 46 insertions(+), 28 deletions(-)