Wireshark-commits: [Wireshark-commits] master 6fbb1d5: BTATT: avoid crashing when called directly t

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 Nov 2019 12:49:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6fbb1d5c665bf7d6bcc4308021d08fb83c17f3d9
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6fbb1d5 by Pascal Quantin (pascal@xxxxxxxxxxxxx):

    BTATT: avoid crashing when called directly through user DLT
    
    Check the bluetooth_data pointer validity before using it for the
    red-black tree key. It should be non nul when called from another
    dissector, but it's not the case when you call btatt dissector
    directly through a user DLT.
    
    Bug: 16104
    Change-Id: Ic572d639a8695b93102529a45b99ff6c3c7def03
    Reviewed-on: https://code.wireshark.org/review/34948
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  013e87a   Qt: Remove DisplayFilterMimeData
     add  6fbb1d5   BTATT: avoid crashing when called directly through user DLT


Summary of changes:
 epan/dissectors/packet-btatt.c | 211 +++++++++++++++++++++++------------------
 1 file changed, 119 insertions(+), 92 deletions(-)