Wireshark-commits: [Wireshark-commits] master 3a0b512: HomePlug AV: Fix dissection of MMTYPE and FM

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 27 Oct 2019 23:21:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a0b512b11ad8994e8c6026c0dae4c0007d005ec
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3a0b512 by John Serock (serock-wireshark-dev@xxxxxxxxxxx):

    HomePlug AV: Fix dissection of MMTYPE and FMI
    
    Get MMTYPE MSB from the three most significant bits, bits 5 through 7,
    instead of bits 1 and 2. Get FMI Fragment count from the four most
    significant bits instead of the four least significant bits. Get FMI
    Fragment index from the four least significant bits instead of the four
    most significant bits.
    
    Bug: 16158
    Change-Id: Ib51789486be4562f76114081cbbf3aa22a41ff2e
    Reviewed-on: https://code.wireshark.org/review/34868
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c9c33af   Add more checks, fail for negative byte block lengths.
     add  3a0b512   HomePlug AV: Fix dissection of MMTYPE and FMI


Summary of changes:
 epan/dissectors/packet-homeplug-av.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)