URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a1b16a4f8e935dde8ec54ca216a2384a3ee27fda
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
a1b16a4 by Vadim Yanitskiy (axilirator@xxxxxxxxx):
GSM RLC/MAC: distinguish TA Index / TS number for Uplink and Downlink
According to 3GPP TS 44.060, section 12.12a "Global Packet Timing
Advance", there may be five optional fields in this IE:
- TIMING_ADVANCE_VALUE,
- UPLINK_TIMING_ADVANCE_INDEX,
- UPLINK_TIMING_ADVANCE_TIMESLOT_NUMBER,
- DOWNLINK_TIMING_ADVANCE_INDEX,
- DOWNLINK_TIMING_ADVANCE_TIMESLOT_NUMBER.
For the last 4 fields we should clearly distinguish between
the Uplink and Downlink. Otherwise it looks confusing:
Common_Timeslot_Reconfigure_Data.Global_Packet_Timing_Advance
..0. .... = TIMING_ADVANCE_VALUE Exist: 0
...0 .... = TIMING_ADVANCE_INDEX Exist: 0
.... 1... = TIMING_ADVANCE_INDEX Exist: 1
.... .001 0... .... = TIMING_ADVANCE_INDEX: 2
.110 .... = TIMING_ADVANCE_TIMESLOT_NUMBER: 6
After this patch:
Common_Timeslot_Reconfigure_Data.Global_Packet_Timing_Advance
..0. .... = TIMING_ADVANCE_VALUE Exist: 0
...0 .... = UPLINK_TIMING_ADVANCE_INDEX Exist: 0
.... 1... = DOWNLINK_TIMING_ADVANCE_INDEX Exist: 1
.... .001 0... .... = DOWNLINK_TIMING_ADVANCE_INDEX: 2
.110 .... = DOWNLINK_TIMING_ADVANCE_TIMESLOT_NUMBER: 6
Change-Id: I65d7fa579ebbd7af49c03875810444352333a5a0
Reviewed-on: https://code.wireshark.org/review/34712
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from a758e31 CMake: Include glib dlls in Windows installer
add a1b16a4 GSM RLC/MAC: distinguish TA Index / TS number for Uplink and Downlink
Summary of changes:
epan/dissectors/packet-gsm_rlcmac.c | 55 +++++++++++++++++++++++++++++++++----
1 file changed, 49 insertions(+), 6 deletions(-)