URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7f5ba6aa7d6d56a7c375c02c911f61fc257d51f
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
e7f5ba6 by Tomasz Moń (desowin@xxxxxxxxx):
Qt: Do not redissect packets before sorting
There's no need to perform redissection as we are sorting data already
present in PacketListRecord.
This change is not only improving performance, but prevents a crash
related to "event interruptions". As wsApp->processEvents() is called
with QEventLoop::AllEvents, it is possible for user to trigger any
action. If the user decided to close the file while packets are being
redissected inside PacketListModel::sort(), Wireshark would crash.
Ping-Bug: 16097
Change-Id: I82eee0efc789a1102e5fbe3670ed79039a18b8be
Reviewed-on: https://code.wireshark.org/review/34679
Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 9e686f1 PFCP: Change of framed-route and framed-ipv6-route formating.
add e7f5ba6 Qt: Do not redissect packets before sorting
Summary of changes:
ui/qt/models/packet_list_model.cpp | 24 +-----------------------
1 file changed, 1 insertion(+), 23 deletions(-)