Wireshark-commits: [Wireshark-commits] master 3367cba: Improve the handling of the FT (Frame Type)

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 29 Sep 2019 23:13:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3367cbab17769658872decc78762c8edf681fe43
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3367cba by Guy Harris (guy@xxxxxxxxxxxx):

    Improve the handling of the FT (Frame Type) field in Type III headers.
    
    Show the value symbolically, and don't dissect the payload as an
    Ethernet packet if the value isn't 0, meaning "Ethernet".
    
    This gets rid of the mis-dissection of the payload in the capture
    atttached to bug 16089, although it doesn't dissect it any further, as
    we don't know how to dissect it.
    
    Change-Id: I97fce0f7a4f4336339bc90271aa7b19c97831abe
    Ping-Bug: 16089
    Reviewed-on: https://code.wireshark.org/review/34649
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c60708d   Fix build on Fedora 30 (minizip)
     add  3367cba   Improve the handling of the FT (Frame Type) field in Type III headers.


Summary of changes:
 epan/dissectors/packet-cisco-erspan.c | 32 ++++++++++++++++++++++++++------
 1 file changed, 26 insertions(+), 6 deletions(-)