URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=983d7c3a0002e97162a98a2a93f59d7290131dd9
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
983d7c3 by Peter Wu (peter@xxxxxxxxxxxxx):
QUIC: move Short Header fields under a new tree
Most of the Short Header fields are not interesting during frame
analysis. Move these under a new tree that can be collapsed. Example:
QUIC IETF
[Packet Length: 142]
QUIC Short Header DCID=dc65691dc735aa73 PKN=3
0... .... = Header Form: Short Header (0)
.1.. .... = Fixed Bit: True
..0. .... = Spin Bit: False
...0 0... = Reserved: 0
.... .0.. = Key Phase Bit: False
.... ..01 = Packet Number Length: 2 bytes (1)
Destination Connection ID: dc65691dc735aa73
Packet Number: 3
Protected Payload: 0720f67fc1fad0b14a14d8a9ff41b3119ce077e6088c21c2…
TLSv1.3 Record Layer: Handshake Protocol: New Session Ticket
STREAM Stream ID: 3
STREAM Stream ID: 7
STREAM Stream ID: 11
Use proto_tree_add_item + proto_item_add_subtree instead of
proto_tree_add_subtree to ensure a usable `tshark -Tjson` output using
"quic.short" as key instead of "QUIC Short Header DCID=...".
Change-Id: Ic5ae177c7d573005259224b0155cf2d802f7fc21
Ping-Bug: 13881
Reviewed-on: https://code.wireshark.org/review/34586
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from b43177e Qt: Fix invalid pointer for model
add 983d7c3 QUIC: move Short Header fields under a new tree
Summary of changes:
epan/dissectors/packet-quic.c | 49 ++++++++++++++++++++++++++++---------------
1 file changed, 32 insertions(+), 17 deletions(-)