Wireshark-commits: [Wireshark-commits] master 9159c06: Couchbase: Handle extras in mutation respons

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 16 Sep 2019 16:20:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9159c060bcc125c65dd76e477b5e2f5548bec0c1
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9159c06 by Matt Carabine (matt.carabine@xxxxxxxxxxxxx):

    Couchbase: Handle extras in mutation responses
    
    Previously extras in any mutation (e.g. ADD, SET) response would
    be marked as illegal, as these used to return no extras.
    More recently, extras can be returned in mutations if the
    connection has negotiated the MUTATION_SEQNO feature.
    The extras can contain the mutation's sequence number and the
    vBucket UUID.
    This commit adds a new field (couchbase.extras.mutation_seqno) to
    achieve this, as the existing field couchbase.extras.seqno is used
    for a different purpose and is only a UINT32, whereas a UINT64 is
    returned as part of the extras; the existing
    couchbase.extras.vbucket_uuid is used for the vBucket UUID.
    
    Change-Id: If8a5148f2115fce7a777b96ad22ba92d95c9ff71
    Reviewed-on: https://code.wireshark.org/review/34540
    Reviewed-by: Dave Rigby <daver@xxxxxxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ac5d7af   pfcp: update of UP Function Features IE
     add  9159c06   Couchbase: Handle extras in mutation responses


Summary of changes:
 epan/dissectors/packet-couchbase.c | 36 +++++++++++++++++++++++++++++-------
 1 file changed, 29 insertions(+), 7 deletions(-)