Wireshark-commits: [Wireshark-commits] master 43c053e: BACnet: Wrong dissection device identifier

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 Sep 2019 19:24:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=43c053e2be3871e4cacf821ca8532174db504807
Submitter: "Jaap Keuter <jaap.keuter@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

43c053e by Dirk Römmen (dro@xxxxxxxx):

    BACnet: Wrong dissection device identifier
    
    - Implemented labeling of decoding BACnet object identifier so that
      difference between device and other object id's are shown in the
      decoding tree.
    
    Bug: 16008
    Change-Id: I145e26803e1b6c70c2980858c1b946a285382726
    Reviewed-on: https://code.wireshark.org/review/34340
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  841c27c   802.11 radiotap: Fix wrong data structure in the dissector for HE TRIGGER frames
     add  43c053e   BACnet: Wrong dissection device identifier


Summary of changes:
 epan/dissectors/packet-bacapp.c | 123 ++++++++++++++++++++--------------------
 1 file changed, 62 insertions(+), 61 deletions(-)