[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a53545c0c81ac71aaa10ae91d080f1640551b5b8
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a53545c by Roland Knall (rknall@xxxxxxxxx):

    Qt: Add macro for g_list_next for C++
    
    Using a simple (type *) cast on g_list_next results in a warning
    with modern compilers "old-style cast"
    
    Adding a warning for g_list_next and data access to avoid the warning
    
    A good overview why reinterpret_cast has been used can be found here:
    
    https://stackoverflow.com/questions/332030/when-should-static-cast-dynamic-cast-const-cast-and-reinterpret-cast-be-used
    
    It is a 1:1 replacement in this case, but does not use any of the new
    cast styles and therefore should be used with caution.
    
    Change-Id: I989f237afc39aaf40133a788b1c0bbd7a51bf974
    Reviewed-on: https://code.wireshark.org/review/34284
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  b43ff70   NAS 5GS: update 5GSM cause table
     add  a53545c   Qt: Add macro for g_list_next for C++


Summary of changes:
 ui/qt/capture_interfaces_dialog.cpp    | 26 ++++++++---------
 ui/qt/extcap_options_dialog.cpp        | 18 ++++++------
 ui/qt/filter_dialog.cpp                |  4 +--
 ui/qt/follow_stream_dialog.cpp         | 18 ++++++------
 ui/qt/iax2_analysis_dialog.cpp         |  8 +++---
 ui/qt/main_window.cpp                  | 40 +++++++++++++-------------
 ui/qt/main_window_slots.cpp            |  4 +--
 ui/qt/manage_interfaces_dialog.cpp     | 10 +++----
 ui/qt/models/interface_tree_model.cpp  |  4 +--
 ui/qt/models/pref_models.cpp           |  4 +--
 ui/qt/models/profile_model.cpp         |  2 --
 ui/qt/models/voip_calls_info_model.cpp |  4 +--
 ui/qt/multicast_statistics_dialog.cpp  |  4 +--
 ui/qt/preferences_dialog.cpp           | 16 ++++++-----
 ui/qt/rtp_analysis_dialog.cpp          |  6 ++--
 ui/qt/rtp_stream_dialog.cpp            |  6 ++--
 ui/qt/sctp_all_assocs_dialog.cpp       |  6 ++--
 ui/qt/sctp_assoc_analyse_dialog.cpp    | 20 ++++++-------
 ui/qt/sctp_graph_arwnd_dialog.cpp      | 14 ++++-----
 ui/qt/sctp_graph_byte_dialog.cpp       | 14 ++++-----
 ui/qt/sctp_graph_dialog.cpp            | 52 +++++++++++++++++-----------------
 ui/qt/sequence_diagram.cpp             |  8 +++---
 ui/qt/utils/qt_ui_utils.h              | 10 +++++++
 ui/qt/voip_calls_dialog.cpp            | 32 ++++++++++-----------
 ui/qt/widgets/additional_toolbar.cpp   | 14 ++++-----
 ui/qt/widgets/capture_filter_combo.cpp |  4 +--
 ui/qt/widgets/capture_filter_edit.cpp  | 16 +++++------
 ui/qt/widgets/display_filter_edit.cpp  | 17 +++++------
 28 files changed, 196 insertions(+), 185 deletions(-)