Wireshark-commits: [Wireshark-commits] master 22b5495: Qt: Fix CredentialsModel::clear()

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Aug 2019 19:58:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22b5495485b3359fd62a39bedf2251c48f411a87
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

22b5495 by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Fix CredentialsModel::clear()
    
    The last parameter to beginRemoveRows() is the last row index, not the
    number of rows. The QAbstractItemModel::beginRemoveRows() source code
    expliticly checks if the value is smaller than row count.
    
    Do not emit beginRemoveRows() if the model is empty as it does not make
    sense and it is impossible to pass the QAbstractItemModel assertions
    in such case.
    
    Emit endRemoveRows() when finished instead of endInsertRows().
    
    Change-Id: I93be4820b1ea0fbb5c0f3cd28edca329b4017814
    Reviewed-on: https://code.wireshark.org/review/34318
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  97a9c7a   NAS 5GS: decode LPP payload
     add  22b5495   Qt: Fix CredentialsModel::clear()


Summary of changes:
 ui/qt/models/credentials_model.cpp | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)