Wireshark-commits: [Wireshark-commits] master 0428638: dhcp: fix memleak on exceptions in dissect_d

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Jul 2019 06:13:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0428638a24f2616739cb795ff7ddddbf5b8a1424
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

0428638 by Peter Wu (peter@xxxxxxxxxxxxx):

    dhcp: fix memleak on exceptions in dissect_dhcpopt_avaya_ip_telephone
    
    Do not use g_malloc, it leaks when accessing the tvb throws an error.
    
    Change-Id: I5c6515da2184e2bea496d352461784cf845c3e18
    Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15673
    Fixes: v3.1.0rc0-136-gc28d8f937a ("packet-dhcp.c: Fix modification of a const char* string")
    Reviewed-on: https://code.wireshark.org/review/33999
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1da2caa   CoAP: add frame support for CoAP over TCP, TLS, WebSockets (RFC 8323)
     add  0428638   dhcp: fix memleak on exceptions in dissect_dhcpopt_avaya_ip_telephone


Summary of changes:
 epan/dissectors/packet-dhcp.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)