Wireshark-commits: [Wireshark-commits] master 81e2d2a: Don't just grab raw string data with tvb_mem

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 17 Jul 2019 01:56:08 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=81e2d2a668cc06e53168623af19718c03f68ab1d
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

81e2d2a by Guy Harris (guy@xxxxxxxxxxxx):

    Don't just grab raw string data with tvb_memcpy().
    
    Use tvb_get_string_enc() routines to fetch them; all strings must have
    an encoding value, to properly map to UTF-8.
    
    While we're at it, fix heuristic test to make sure we have a full TALI
    header in the *captured* data.
    
    Change-Id: Ia572707f8d7da89d3fe31e839e1cbe4dc5e23c43
    Reviewed-on: https://code.wireshark.org/review/33980
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  705942f   Ask in a comment about DNS-style domain names.
     add  81e2d2a   Don't just grab raw string data with tvb_memcpy().


Summary of changes:
 epan/dissectors/packet-tali.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)