Wireshark-commits: [Wireshark-commits] master 3ada703: Have the message data just be a raw FT_BYTES

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 12 Jul 2019 07:12:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3ada70356fc6276c71a54964c32fe620e1877bbb
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3ada703 by Guy Harris (guy@xxxxxxxxxxxx):

    Have the message data just be a raw FT_BYTES field.
    
    If somebody wants it interpreted, they should submit code to do so,
    *along with a sample capture*, so we can see how it's *supposed* to be
    interpreted - the way it was being interpreted makes no sense for
    several reasons.
    
    Change-Id: I2dbcb3915fd7d7d1b4a27be627f395ac43bc4130
    Reviewed-on: https://code.wireshark.org/review/33905
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2dd367a   Squelch more -Wpointer-sign warnings.
     add  3ada703   Have the message data just be a raw FT_BYTES field.


Summary of changes:
 epan/dissectors/packet-armagetronad.c | 49 +++++++++++++++--------------------
 1 file changed, 21 insertions(+), 28 deletions(-)