Wireshark-commits: [Wireshark-commits] master d95262b: Qt: Remove unnecessary ColumnText object

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 16 Jun 2019 21:07:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d95262bf7420ba56ccfded85ebeec6f32ea7069a
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d95262b by Roland Knall (rknall@xxxxxxxxx):

    Qt: Remove unnecessary ColumnText object
    
    wmem should not be used inside a model, as the memory managment of
    those models is part of the responsibility of Qt. It could happen,
    that the file is closed, but the model still needs to access the
    information, in which case the memory access fails.
    
    Change-Id: I740a4bae61cc32f0f0245515c23abf175ef588f1
    Reviewed-on: https://code.wireshark.org/review/33622
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  64badc5   Qt: Allow Drag-and-drop on info and protocol
     add  d95262b   Qt: Remove unnecessary ColumnText object


Summary of changes:
 ui/qt/models/packet_list_model.cpp  | 10 ++++----
 ui/qt/models/packet_list_record.cpp | 50 ++++++++++++++++---------------------
 ui/qt/models/packet_list_record.h   |  7 +++---
 3 files changed, 31 insertions(+), 36 deletions(-)