URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce4a2816ff66ae5a7cf45fec10ac85fcbb66cef9
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
ce4a281 by Guy Harris (guy@xxxxxxxxxxxx):
Pull get_unicode_or_ascii_string() into packet-smb.c.
Nobody else needs its extra stuff, as they're not pulling data out of an
SMB byte buffer, so they don't need the extra length check, and nobody
else uses it - or should use it, as we now have support for string
encodings in the tvbuff and protocol-tree code.
Change-Id: I8d249ea2c89a744eef12a05ad755811c07ca463a
Reviewed-on: https://code.wireshark.org/review/33581
Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from fb0d1ee Qt: fix 'open protocol preferences' shortcut for protocol subtrees
add ce4a281 Pull get_unicode_or_ascii_string() into packet-smb.c.
Summary of changes:
epan/dissectors/packet-smb-common.c | 156 -----------------------------------
epan/dissectors/packet-smb-common.h | 4 -
epan/dissectors/packet-smb.c | 157 ++++++++++++++++++++++++++++++++++++
3 files changed, 157 insertions(+), 160 deletions(-)