URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e3e606ce02d1a87695de22a1637d31429c0fd4de
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
e3e606c by Guy Harris (guy@xxxxxxxxxxxx):
Get rid of get_unicode_or_ascii_string() calls in the SMB2 dissector.
The extra stuff done by that routine isn't needed for SMB2 strings,
which are always aligned on a 2-byte boundary if they're Unicode
strings. Just choosing the right type (FT_STRING or FT_STRINGZ) and
using proto_tree_add_item() - or proto_tree_add_item_ret_string() if the
string value is required - suffices. Using
proto_string_item_get_display_string() means we don't need the string
value in most cases.
Update and move a URL, putting Microsoft's references at the top of the
list of documentation links, and adding MS-FSCC.
Make the string fields STR_UNICODE.
Change-Id: Iad1a31dacad93e7b5ad43033c740fa00abbe86e7
Reviewed-on: https://code.wireshark.org/review/33518
Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from ee35570 Improve handling of binary data that *might* be text.
add e3e606c Get rid of get_unicode_or_ascii_string() calls in the SMB2 dissector.
Summary of changes:
epan/dissectors/packet-smb2.c | 379 +++++++++++++++++-------------------------
1 file changed, 152 insertions(+), 227 deletions(-)