Wireshark-commits: [Wireshark-commits] master-3.0 79e5de6: Fix the dissection of Find First2 Query

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 04 Jun 2019 22:17:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=79e5de625a11d8c59a13960b3f1d106353e0986b
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

79e5de6 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix the dissection of Find First2 Query EA Info information.
    
    The file name doesn't appear to be padded, and may have a 1-byte null
    terminator (yes, 1 byte, according to MS-CIFS) at the end, not included
    in the file name length.
    
    Change-Id: I8510434b3b5aec092290697c336924d6ff6be763
    Reviewed-on: https://code.wireshark.org/review/33486
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit d1da455164e8e046c4b146612a47c398cffb6bb4)
    Reviewed-on: https://code.wireshark.org/review/33490
    

Actions performed:

    from  8353122   Handle some weirdness with the primary domain field in NegProt replies.
     add  79e5de6   Fix the dissection of Find First2 Query EA Info information.


Summary of changes:
 epan/dissectors/packet-smb.c | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)