Wireshark-commits: [Wireshark-commits] master f0c13af: Don't assume an NT Create AndX request has a

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 04 Jun 2019 19:45:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0c13af7d3862f11b47cfcb12ccc80341122395d
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f0c13af by Guy Harris (guy@xxxxxxxxxxxx):

    Don't assume an NT Create AndX request has all the word parameters.
    
    It *should*, but a malicious or otherwise malformed packet might not
    have them.  One of them is the file name length; if it's missing, we
    can't dissect the file name, as we don't know how long it is.
    
    Change-Id: Ie259e2d8ec65f5d53d466382d89889902495d2c8
    Reviewed-on: https://code.wireshark.org/review/33467
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7b12f11   Reassemble PLP chunks.
     add  f0c13af   Don't assume an NT Create AndX request has all the word parameters.


Summary of changes:
 epan/dissectors/packet-smb.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)