URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=38dec96c656e438e1f09f7dda6327b85ffd0c479
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
38dec96 by Guy Harris (guy@xxxxxxxxxxxx):
*Always* pair ENC_UTF_16 and ENC_UCS_2 with a byte order.
Big-endian and little-endian UTF-16 and UCS-2 aren't the same; always
associate them with a byte order ENC_ flag, to clarify what byte order
is being used. Yes, for big-endian, omitting the ENC_ flag, or using
ENC_NA, *happens* to work, because ENC_BIG_ENDIAN and ENC_NA *happen* to
be 0, but omitting ENC_BIG_ENDIAN doesn't make it sufficiently clear
that it's UTF-16BE or UCS-2BE.
Change-Id: Iecf7375763ce4922bd1b0676c9dc5a01731c2fec
Reviewed-on: https://code.wireshark.org/review/33374
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from a348193 wslua: fix error handling for invalid dissector table
add 38dec96 *Always* pair ENC_UTF_16 and ENC_UCS_2 with a byte order.
Summary of changes:
epan/dissectors/packet-hiqnet.c | 12 ++++++------
epan/dissectors/packet-isobus-vt.c | 6 +++---
2 files changed, 9 insertions(+), 9 deletions(-)