Wireshark-commits: [Wireshark-commits] master-2.6 6aa4428: *Little-endian* UTF-16.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 May 2019 02:34:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6aa4428c89969e6fece4edd0712dd7f423dda8f8
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

6aa4428 by Guy Harris (guy@xxxxxxxxxxxx):

    *Little-endian* UTF-16.
    
    ENC_UTF_16 does *not* go with ENC_NA; ENC_NA is for cases where the byte
    order is "not applicable", such as a 1-byte number or a character
    encoding where every character is encoded in 1 byte, but UTF-16 isn't
    one of those cases, as a character is encoded in either 1 or 2 2-byte
    values.  This being a Windows thing, the byte order is little-endian.
    
    Change-Id: Iab0db3fa2c5d2c25be209e4ed0ebd57827edbcd8
    Reviewed-on: https://code.wireshark.org/review/33347
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 2114dba1effebba50cdb611b2650b0a4a37761e4)
    Reviewed-on: https://code.wireshark.org/review/33349
    

Actions performed:

    from  5a9123e   "OEM Codepage" appears to mean "code page number"; show it in decimal.
     add  6aa4428   *Little-endian* UTF-16.


Summary of changes:
 epan/dissectors/packet-tnef.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)