Wireshark-commits: [Wireshark-commits] master-3.0 13b8e41: mmdbresolve: Improve our main loop check

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 15 May 2019 15:38:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=13b8e41d9f75575e5d9e64bb6742182f81d32949
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

13b8e41 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    mmdbresolve: Improve our main loop check.
    
    Check the return value of fscanf() instead of relying on feof(). This
    should help ensure that we exit correctly.
    
    Bug: 15777
    Change-Id: I8b5985f6015cb6a85378db5135b29bb2c3de1e90
    Reviewed-on: https://code.wireshark.org/review/33196
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 276d62b639c2dbbe8ada823c2ca714daccbd0ce7)
    Reviewed-on: https://code.wireshark.org/review/33206
    

Actions performed:

    from  cd855bc   Fix SMB2 decryption on big-endian machines.
     add  13b8e41   mmdbresolve: Improve our main loop check.


Summary of changes:
 mmdbresolve.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)