Wireshark-commits: [Wireshark-commits] master 88096e1: GSM MAP: Fix dissection of authenticationSet

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 May 2019 11:49:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=88096e1fc5ce41ecf1c8ab8a642c237c121f5444
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

88096e1 by Anders Broman (anders.broman@xxxxxxxxxxxx):

    GSM MAP: Fix dissection of authenticationSet in SentParameterList
    
    Ber choice called with a non FT_UINT hf variable. Work around by
    duplicating ASN1 code.
    
    Change-Id: I71b38e25288f222058793110eb43c122c012dcca
    Reviewed-on: https://code.wireshark.org/review/33191
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fed0e7c   PROFINET DCP: fix dissection of an empty DHCP option
     add  88096e1   GSM MAP: Fix dissection of authenticationSet in SentParameterList


Summary of changes:
 epan/dissectors/asn1/gsm_map/GSMMAP.asn           | 10 +++++-
 epan/dissectors/asn1/gsm_map/MAP-MS-DataTypes.asn |  2 ++
 epan/dissectors/packet-gsm_map.c                  | 44 ++++++++++++++++++++---
 3 files changed, 50 insertions(+), 6 deletions(-)