Wireshark-commits: [Wireshark-commits] master 3234152: Fix SMB2 decryption on big-endian machines.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 May 2019 01:30:40 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3234152bec1d1245cc0a8288c9be90242e2a11ed
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3234152 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix SMB2 decryption on big-endian machines.
    
    Convert the host-endian session ID passed to seskey_find_sid_key()
    before comparing it with the little-endian session IDs in the UAT.
    
    While we're at it, tag session ID fields in various structures with the
    byte order.
    
    Bug: 15772
    Change-Id: Ib1e7323bad1dfdb1ac24a08998205650f2744097
    Reviewed-on: https://code.wireshark.org/review/33188
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  736052b   RLC-NR: Attempt reassembly of UM PDUs.
     add  3234152   Fix SMB2 decryption on big-endian machines.


Summary of changes:
 epan/dissectors/packet-smb2.c | 21 +++++++++++++++++++--
 epan/dissectors/packet-smb2.h |  8 ++++----
 2 files changed, 23 insertions(+), 6 deletions(-)