Wireshark-commits: [Wireshark-commits] master e2f1282: Set the length of the DDP tvbuff based on th

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 10 May 2019 00:54:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e2f12827b273d44cb182cf2b962e9116b4904179
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e2f1282 by Guy Harris (guy@xxxxxxxxxxxx):

    Set the length of the DDP tvbuff based on the length in the header.
    
    And, for DDP packets, set the length in the LLAP tvbuff based on the
    length to which the DDP dissector set its tvbuff.
    
    That lets padding be recognized as such, and also prevents dissectors
    called from the DDP dissector from running past the end of the packet.
    
    Report invalid lengths with expert info.
    
    Change-Id: Icc6ed222a4e7b33463c7c0b02c954952fe21949a
    Reviewed-on: https://code.wireshark.org/review/33142
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ab7ee92   gitlab-ci: use new base image, drop gcc-4 job
     add  e2f1282   Set the length of the DDP tvbuff based on the length in the header.


Summary of changes:
 epan/dissectors/packet-atalk.c | 69 +++++++++++++++++++++++++++++++++++++-----
 1 file changed, 62 insertions(+), 7 deletions(-)