Wireshark-commits: [Wireshark-commits] master 2991770: SysEx: Split DigiTech commands dissection

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 07 May 2019 15:35:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2991770dbee9e30f2cb87e141bf64689959fa3d2
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2991770 by Tomasz Moń (desowin@xxxxxxxxx):

    SysEx: Split DigiTech commands dissection
    
    Every SysEx Manufacturer can decide its own SysEx message format.
    As there are quite a lot of registered SysEx Manufacturers, it is best
    to not mix all the Manufacturer specific commands in one file.
    
    During the extraction following have been changed:
      * sysex.digitech prefix changed to sysex_digitech
      * sysex.device_id changed to sysex_digitech.device_id as the MIDI
        System Exclusive specification doesn't specify anything except the
        (Extended) Manufacturer ID
      * sysex.digitech.device_id renamed to sysex_digitech.received_device_id
        as this field is part of the Who Am I command response
      * Remove the PROTO_CHECKSUM_ZERO flag - the actual checksum is simply
        XOR of all bytes. Prior this change the actual checksum byte was
        XORed together with the checksummed data.
    
    Change-Id: I225149f16a83b7629ce4bf9f6ca81c1d93dd856a
    Reviewed-on: https://code.wireshark.org/review/33070
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1479620   Update tshark man pages for -j and -J
     add  2991770   SysEx: Split DigiTech commands dissection


Summary of changes:
 epan/dissectors/CMakeLists.txt                     |    1 +
 epan/dissectors/packet-sysex.c                     | 1275 +-------------------
 .../{packet-sysex.c => packet-sysex_digitech.c}    |  902 ++------------
 3 files changed, 133 insertions(+), 2045 deletions(-)
 copy epan/dissectors/{packet-sysex.c => packet-sysex_digitech.c} (59%)