Wireshark-commits: [Wireshark-commits] master-2.6 cd33b10: Fix dissection of DDP length and checksu

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 07 May 2019 03:33:22 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cd33b10c80096127c8d244c256337723a9bb5dd3
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

cd33b10 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix dissection of DDP length and checksum fields.
    
    The DDP length is 10 bits long, not 2 bits long; it includes the bottom
    2 bits of the first octet *and* all 8 bits of the second octet.
    
    The checksum is at an offset of 2, not 0, from the beginning of the header.
    
    Change-Id: I7e2b8eff4d023f80a894f1e1eec7b71d08510f7e
    Reviewed-on: https://code.wireshark.org/review/33094
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 9f9e69411b02c1a7e669b39928798403e2dc8fff)
    Reviewed-on: https://code.wireshark.org/review/33096
    

Actions performed:

    from  00faf5e   [Automatic update for 2019-05-05]
     add  cd33b10   Fix dissection of DDP length and checksum fields.


Summary of changes:
 epan/dissectors/packet-atalk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)