Wireshark-commits: [Wireshark-commits] master f0a3431: Don't use the result of please_report_bug()

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 01 May 2019 19:42:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0a34311a063356a6c3b5924267ceca1b09d2d8c
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f0a3431 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use the result of please_report_bug() as a format string.
    
    It prevents format checking; use "%s" as the format string.
    
    Change-Id: Ic05ed64f4b2b6c243f072b0b306e0e06aa1eb3fd
    Reviewed-on: https://code.wireshark.org/review/33041
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  163d01b   USB Audio: Dissect version 2 Audio Control header
     add  f0a3431   Don't use the result of please_report_bug() as a format string.


Summary of changes:
 dumpcap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)