Wireshark-commits: [Wireshark-commits] master cec5991: Windows: Modernize our WSAStartup usage.

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 01 May 2019 17:52:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cec5991f40887b4b2add594e7d82857d475224aa
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

cec5991 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Windows: Modernize our WSAStartup usage.
    
    Make sure we link each application that calls WSAStartup with ws2_32.lib.
    Pass version 2.2 to WSAStartup. Wikipedia says it was introduced in 1996,
    so we should be OK.
    
    Ping-Bug: 15711
    Change-Id: I431839e930e7c646669af7373789640b5180ec28
    Reviewed-on: https://code.wireshark.org/review/33033
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  3a2e290   QUIC: fix transport parameter heuristics for draft -18 and older
     add  cec5991   Windows: Modernize our WSAStartup usage.


Summary of changes:
 CMakeLists.txt                           | 10 ++++++----
 docbook/wsdg_src/WSDG_chapter_tools.adoc |  2 +-
 dumpcap.c                                |  4 +---
 extcap/CMakeLists.txt                    |  6 ++++++
 extcap/androiddump.c                     |  2 +-
 extcap/ciscodump.c                       |  2 +-
 extcap/randpktdump.c                     |  2 +-
 extcap/sshdump.c                         |  2 +-
 extcap/udpdump.c                         |  2 +-
 rawshark.c                               |  2 +-
 sharkd_daemon.c                          |  2 +-
 tshark.c                                 |  2 +-
 ui/qt/main.cpp                           |  2 +-
 wsutil/CMakeLists.txt                    |  2 +-
 14 files changed, 24 insertions(+), 18 deletions(-)