Wireshark-commits: [Wireshark-commits] master 66f829b: win32-utils: Do not share job between Wiresh

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 25 Apr 2019 16:04:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=66f829bc1803df0f4518a98a57a604a05beee6f6
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

66f829b by Tomasz Moń (desowin@xxxxxxxxx):

    win32-utils: Do not share job between Wireshark instances
    
    Creating Job Object named "Local\Wireshark child process cleanup"
    results in the job being shared between all Wireshark instances run
    within a single session.
    
    When two or more Wireshark instances were running, debug message appeared:
    "Could not assign child cleanup process: Access is denied.  (5)"
    
    As the child process was not assigned to a job, it was possible that the
    child process was still active even after Wireshark did terminate.
    
    This fixes the issue by creating unnamed job object which is not shared.
    
    Change-Id: I59adc2aacff0151802163f155d68cbc8022c1479
    Reviewed-on: https://code.wireshark.org/review/32985
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  504da93   RSVP: allow full range of RRO type values
     add  66f829b   win32-utils: Do not share job between Wireshark instances


Summary of changes:
 wsutil/win32-utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)