Wireshark-commits: [Wireshark-commits] master 7a89e6a: CIP Security: Fix some off by 1

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 17 Apr 2019 04:35:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a89e6ad5656e677976062b750acebf16b99c393
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7a89e6a by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP Security: Fix some off by 1
    
    Some offsets were not incremented after being read, but the next field
    assumed it was incremented.
    
    Change-Id: Ifb523bc37f454cfc76d077d34c3efa2663fb6b9e
    Reviewed-on: https://code.wireshark.org/review/32873
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  da84839   DCOM - Add dissector for IProvideClassInfo
     add  7a89e6a   CIP Security: Fix some off by 1


Summary of changes:
 epan/dissectors/packet-enip.c | 4 ++++
 1 file changed, 4 insertions(+)