URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4dda4bac178debe04eac081aa23a951e807f6d31
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
4dda4ba by Dario Lombardo (lomato@xxxxxxxxx):
Qt: use toLocalFile() instead of path() to check for existence.
path() incorrectly gives paths as /C:/Program Files/Wireshark/udpdump.html
under windows. The leading slash gives a wrong test on the file. Instead
toLocalFile() handles it correctly. isLocalFile() has been used to get if
we have a local file or a network URL. The reported bug occurred under Windows
only, but the change is compatible with Linux paths as well.
Accidentally when the test on the file was successful, nothing got called.
The routine has been reworked to open an existing local file.
Bug: 15592
Change-Id: Id6e3a91dfb4c9d20ae8cb0735eabab64caeff47f
Reviewed-on: https://code.wireshark.org/review/32772
Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Actions performed:
from 96fa471 LDP: Support RFC7140 (Extensions for HSMP LSP)
add 4dda4ba Qt: use toLocalFile() instead of path() to check for existence.
Summary of changes:
ui/qt/extcap_options_dialog.cpp | 22 +++++++++-------------
1 file changed, 9 insertions(+), 13 deletions(-)