Wireshark-commits: [Wireshark-commits] master b39a736: iseries: ensure the buffer is null terminate

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 04 Apr 2019 06:17:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b39a736e918294f27b8218c1b2dd8ac82fbb77e6
Submitter: "Dario Lombardo <lomato@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b39a736 by Dario Lombardo (lomato@xxxxxxxxx):

    iseries: ensure the buffer is null terminated.
    
    Check buflen to prevent wrong scanf call as well.
    
    Bug: 15614
    Change-Id: I58a2855d8b1beda067bf9b2d724229ab20249228
    Reviewed-on: https://code.wireshark.org/review/32573
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    

Actions performed:

    from  8d3ac3a   epan: Convert our PROTO_ITEM_ macros to inline functions.
     add  b39a736   iseries: ensure the buffer is null terminated.


Summary of changes:
 wiretap/CMakeLists.txt | 2 +-
 wiretap/iseries.c      | 9 ++++++++-
 2 files changed, 9 insertions(+), 2 deletions(-)