Wireshark-commits: [Wireshark-commits] master-2.4 bfeb259: Remove incorrectly-inserted "return FALS

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 16 Mar 2019 18:53:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bfeb2599468e9d6b07a9fbe276cfae87f2142229
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

bfeb259 by Guy Harris (guy@xxxxxxxxxxxx):

    Remove incorrectly-inserted "return FALSE;".
    
    That made PACKET_DESCRIBE() do nothing, causing warnings from the Clang
    Static Humiliator.
    
    Change-Id: I6f433cd193b6398d89038e95c7bf5deb24aa186d
    Reviewed-on: https://code.wireshark.org/review/32437
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 1660f7437198113c0c90cec22daa6abcd3af22cc)
    Reviewed-on: https://code.wireshark.org/review/32440
    

Actions performed:

    from  842d333   Fix up the checks in nspm_signature_version().
     add  bfeb259   Remove incorrectly-inserted "return FALSE;".


Summary of changes:
 wiretap/netscaler.c | 1 -
 1 file changed, 1 deletion(-)