Wireshark-commits: [Wireshark-commits] master-3.0 5be8e5e: decode-as: Write the entries sorted to f

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 16 Mar 2019 08:21:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5be8e5ee22b273e43037cfa7053123b152451c72
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

5be8e5e by Anders Broman (anders.broman@xxxxxxxxxxxx):

    decode-as: Write the entries sorted to file.
    
    If the list isn't sorted port ranges in preferences get may get "scrambled".
    Try SIP udp.ports 5060, 5062-5064, 5066, 5078 save and open again the
    order is now random. This patch should fix that.
    
    Change-Id: Ic81f5d132d2c28ca982e8719786cdddbd237d37b
    Reviewed-on: https://code.wireshark.org/review/32420
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit a4251ec71dd253fb967de8dbb1420759ef7cb890)
    Reviewed-on: https://code.wireshark.org/review/32433
    

Actions performed:

    from  7ad4f33   TCP: Adding sequence number only once to the tree
     add  5be8e5e   decode-as: Write the entries sorted to file.


Summary of changes:
 epan/decode_as.c | 53 ++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 38 insertions(+), 15 deletions(-)