Wireshark-commits: [Wireshark-commits] master 28c5b73: Updates and bugfixes of ASTERIX
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 08 Mar 2019 05:28:40 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=28c5b73545d33a9eb5fef591bb908b0c0548236e Submitter: "Anders Broman <a.broman58@xxxxxxxxx>" Changed: branch: master Repository: wireshark Commits: 28c5b73 by Atli Guðmundsson (atli@xxxxxxx): Updates and bugfixes of ASTERIX Generic fixes - subfields with small number of bits that belong to large bit fields are not being decoded correctly (they all become zero). Generic update - removed ett_[X] entries that were never being used asterix bugfixes - asterix.SAC bitmask not aligned - asterix.SIC bitmask not aligned I019 bugfixes - I019/552 bitmask not aligned I020 bugfixes - I020/042 incorrect filter - I020/170 too many spare bits - I020/170 incorrect filter - I020/230 incorrect filter - I020/500#01.DOPy incorrect filter - I020/500#03 incorrect filter - I020/RE sub field names not in line with other CATs - I020/RE.GVV.TA is signed (should be unsigned) - I020/RE.GVA.TASD is signed (should be unsigned) - I020/RE.PA#02 incorrect filter - I020/RE.DA#04 incorrect filter I021 bugfixes - I021/110#01 is not a FIXED size field (it is an FX field) - I021/260 bitmask not aligned - I021/RE.MES#02 bitmask not aligned - I021/RE.MES#03 bitmask not aligned - I021/RE.MES#06 bitmask not aligned I034 bugfixes - I034/050 subfield indexes are missing - I034/050#04 bitmask not aligned - I034/060 subfield indexes are missing I048 bugfixes - I048/050 bitmask not aligned - I048/060 bitmask not aligned - I048/070 bitmask not aligned - I048/080 bitmask not aligned - I048/100 bitmask not aligned - I048/120 bitmask not aligned - I048/230 bitmask not aligned - I048/RE.MD5 subfield indexes are followed by a comma - I048/RE.MD5#02 bitmask not aligned - I048/RE.MD5#05 bitmask not aligned - I048/RE.M5N subfield indexes are followed by a comma - I048/RE.M5N#02 bitmask not aligned - I048/RE.M5N#05 bitmask not aligned - I048/RE.RPC subfield indexes are followed by a comma I062 bugfixes - I062/060 bitmask not aligned - I062/080.DUPF incorrect filter - I062/110#02 bitmask not aligned - I062/340#05 bitmask not aligned - I062/380#10 bitmask not aligned - I062/380#11 bitmask not aligned - I062/390#03 bitmask not aligned - I062/390#09.RWY is now a string instead of 3 different fields - I062/390#12 bitmask not aligned - I062/390#17 bitmask not aligned - I062/510 bitmask not aligned - I062/RE.CST bitmask not aligned Change-Id: Ieefb53a10728205f2cefac718ac8668df29f1f8a Reviewed-on: https://code.wireshark.org/review/32300 Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx> Actions performed: from e327892 ieee802154: Show header fields add 28c5b73 Updates and bugfixes of ASTERIX Summary of changes: epan/dissectors/packet-asterix.c | 4414 ++++---------------------------------- 1 file changed, 445 insertions(+), 3969 deletions(-)
- Prev by Date: [Wireshark-commits] master-3.0 88e50bb: ieee802154: Show header fields
- Next by Date: [Wireshark-commits] master b080033: Remove the periodic interface update in wireless toolbar
- Previous by thread: [Wireshark-commits] master-3.0 88e50bb: ieee802154: Show header fields
- Next by thread: [Wireshark-commits] master b080033: Remove the periodic interface update in wireless toolbar
- Index(es):