Wireshark-commits: [Wireshark-commits] master-3.0 46261cb: Pull some common code from the FCS/metad

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 Mar 2019 21:04:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=46261cb5184e90545c7f81ccf7da7c73aea44c53
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

46261cb by Guy Harris (guy@xxxxxxxxxxxx):

    Pull some common code from the FCS/metadata dissectors.
    
    Put the "mark frames with an invalid CRC" stuff into the main dissector
    code, as it's the same regardless of whether you have an FCS that can be
    checked or metadata with an "FCS bad" flag.
    
    Change-Id: I2540c1934032c91f22b66babd81fb928212f18b5
    Reviewed-on: https://code.wireshark.org/review/32280
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 74a776d391b6d7aa1d9662987cc3f09abfb8abaf)
    Reviewed-on: https://code.wireshark.org/review/32327
    

Actions performed:

    from  43e1d19   Have separate routines to dissect an FCS and TI CC24xx metadata.
     add  46261cb   Pull some common code from the FCS/metadata dissectors.


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 41 ++++++++++++++-----------------------
 1 file changed, 15 insertions(+), 26 deletions(-)