Wireshark-commits: [Wireshark-commits] master-3.0 7eb0d77: Don't use a global variable for the FCS

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 Mar 2019 21:03:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7eb0d7702ca7bf2ae1e9ce2c0812b95bdfd41ea1
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

7eb0d77 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use a global variable for the FCS length.
    
    Use local variables and parameters instead.
    
    Change-Id: If491ef9c4e961848bb59f48d107157372f93e43f
    Reviewed-on: https://code.wireshark.org/review/32278
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 371c71ac1e98590eb4fa477e006922dbee66e2c5)
    Reviewed-on: https://code.wireshark.org/review/32325
    

Actions performed:

    from  3d7d492   Don't use the same variable for the configured FCS type and the tap FCS type.
     add  7eb0d77   Don't use a global variable for the FCS length.


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 91 ++++++++++++++++++-------------------
 1 file changed, 44 insertions(+), 47 deletions(-)