Wireshark-commits: [Wireshark-commits] master-3.0 3c5eaa1: Replace a tvb_new_subset_length_caplen()

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 Mar 2019 21:00:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c5eaa150d144f06f5b8754ec7750dfe17a59711
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

3c5eaa1 by Guy Harris (guy@xxxxxxxxxxxx):

    Replace a tvb_new_subset_length_caplen() call with tvb_new_subset_remaining().
    
    It's simpler, and is not incorrectly using the *captured* length to set
    the *reported* length.
    
    Change-Id: If4b7f1c431f4c39dcc568698358667a1b4fc1a12
    Reviewed-on: https://code.wireshark.org/review/32268
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit bf8ca6a605424e6ee23b66ac9a45ef4818268b6d)
    Reviewed-on: https://code.wireshark.org/review/32321
    

Actions performed:

    from  bfe4e1b   Remove FCS length checks from code that's handed a tvbuff without an FCS.
     add  3c5eaa1   Replace a tvb_new_subset_length_caplen() call with tvb_new_subset_remaining().


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)