Wireshark-commits: [Wireshark-commits] master 69460d4: maxmind_db: Work around an apparent GLib bug

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 Mar 2019 18:35:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=69460d44ea7b8883bbe8140868e3ccf4e7dbb981
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

69460d4 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    maxmind_db: Work around an apparent GLib bug.
    
    g_async_queue_timeout_pop can return immediately on macOS and possibly
    other OSes when using older versions of GLib. Replace it with
    g_async_queue_pop and a "stop" sentinel value.
    
    Bug: 15545
    Change-Id: Id0bfacd4a94ec9645d2d27ba92d3a2f48e7d5f37
    Reviewed-on: https://code.wireshark.org/review/32289
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  9887fe3   WSDG: Describe our tag naming conventions.
     add  69460d4   maxmind_db: Work around an apparent GLib bug.


Summary of changes:
 epan/maxmind_db.c | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)